platform/x86: intel-hid: Check ACPI_HANDLE() against NULL
[ Upstream commit 5c69e090ae5dd93d910f70db0796357080707d26 ]
Every platform driver can be forced to match a device that doesn't match
its list of device IDs because of device_match_driver_override(), so
platform drivers that rely on the existence of a device's ACPI companion
object need to verify its presence.
Accordingly, add a requisite ACPI_HANDLE() check against NULL to the
platform/x86 intel-hid driver.
Fixes: ecc83e52b2 ("intel-hid: new hid event driver for hotkeys")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/1971512.tdWV9SEqCh@rafael.j.wysocki
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Ulrich Hecht <uli@kernel.org>
This commit is contained in:
1 parent
1384b55a00
commit
fd514dffdd
1 file changed
+5
-1
@@ -448,12 +448,16 @@ static bool button_array_present(struct platform_device *device)
|
||||
|
||||
static int intel_hid_probe(struct platform_device *device)
|
||||
{
|
||||
acpi_handle handle = ACPI_HANDLE(&device->dev);
|
||||
unsigned long long mode, dummy;
|
||||
struct intel_hid_priv *priv;
|
||||
acpi_handle handle;
|
||||
acpi_status status;
|
||||
int err;
|
||||
|
||||
handle = ACPI_HANDLE(&device->dev);
|
||||
if (!handle)
|
||||
return -ENODEV;
|
||||
|
||||
intel_hid_init_dsm(handle);
|
||||
|
||||
if (!intel_hid_evaluate_method(handle, INTEL_HID_DSM_HDMM_FN, &mode)) {
|
||||
|
||||
Reference in new issue
Block a user