Igor Pylypiv
a0c66ac8b7
Revert "module, async: async_synchronize_full() on module init iff async is used"
...
[ Upstream commit 67d6212afda218d564890d1674bab28e8612170f ]
This reverts commit 774a1221e8 .
We need to finish all async code before the module init sequence is
done. In the reverted commit the PF_USED_ASYNC flag was added to mark a
thread that called async_schedule(). Then the PF_USED_ASYNC flag was
used to determine whether or not async_synchronize_full() needs to be
invoked. This works when modprobe thread is calling async_schedule(),
but it does not work if module dispatches init code to a worker thread
which then calls async_schedule().
For example, PCI driver probing is invoked from a worker thread based on
a node where device is attached:
if (cpu < nr_cpu_ids)
error = work_on_cpu(cpu, local_pci_probe, &ddi);
else
error = local_pci_probe(&ddi);
We end up in a situation where a worker thread gets the PF_USED_ASYNC
flag set instead of the modprobe thread. As a result,
async_synchronize_full() is not invoked and modprobe completes without
waiting for the async code to finish.
The issue was discovered while loading the pm80xx driver:
(scsi_mod.scan=async)
modprobe pm80xx worker
...
do_init_module()
...
pci_call_probe()
work_on_cpu(local_pci_probe)
local_pci_probe()
pm8001_pci_probe()
scsi_scan_host()
async_schedule()
worker->flags |= PF_USED_ASYNC;
...
< return from worker >
...
if (current->flags & PF_USED_ASYNC) <--- false
async_synchronize_full();
Commit 21c3c5d280 ("block: don't request module during elevator init")
fixed the deadlock issue which the reverted commit 774a1221e8
("module, async: async_synchronize_full() on module init iff async is
used") tried to fix.
Since commit 0fdff3ec6d ("async, kmod: warn on synchronous
request_module() from async workers") synchronous module loading from
async is not allowed.
Given that the original deadlock issue is fixed and it is no longer
allowed to call synchronous request_module() from async we can remove
PF_USED_ASYNC flag to make module init consistently invoke
async_synchronize_full() unless async module probe is requested.
Signed-off-by: Igor Pylypiv <ipylypiv@google.com >
Reviewed-by: Changyuan Lyu <changyuanl@google.com >
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org >
Acked-by: Tejun Heo <tj@kernel.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2022-02-23 11:58:38 +01:00
..
2021-03-17 16:43:42 +01:00
2021-08-08 08:54:28 +02:00
2021-06-16 11:55:01 +02:00
2021-04-14 08:22:36 +02:00
2021-03-30 14:37:02 +02:00
2021-09-22 11:47:49 +02:00
2021-12-08 08:50:11 +01:00
2021-05-22 10:59:30 +02:00
2021-09-22 11:47:47 +02:00
2021-08-12 13:19:42 +02:00
2021-05-07 10:49:25 +02:00
2015-08-05 13:38:07 +01:00
2012-10-08 13:50:20 +10:30
2018-06-15 18:10:01 -03:00
2018-06-15 18:10:01 -03:00
2017-02-16 10:08:41 +05:30
2013-03-12 13:59:14 -07:00
2018-06-17 08:27:01 +09:00
2012-03-16 10:38:24 -04:00
2016-10-11 15:06:31 -07:00
2017-11-07 10:32:44 +01:00
2021-08-08 08:54:29 +02:00
2021-08-08 08:54:29 +02:00
2017-11-02 11:10:55 +01:00
2019-12-01 09:17:07 +01:00
2018-06-21 12:52:11 +02:00
2021-03-04 09:39:30 +01:00
2021-09-22 11:47:59 +02:00
2021-03-30 14:37:02 +02:00
2020-04-23 10:30:12 +02:00
2019-10-05 13:09:54 +02:00
2020-12-30 11:25:39 +01:00
2020-09-09 19:04:31 +02:00
2017-11-02 11:10:55 +01:00
2021-09-26 13:39:48 +02:00
2017-11-02 11:10:55 +01:00
2018-01-04 15:13:29 -08:00
2017-11-02 11:10:55 +01:00
2018-07-19 17:08:52 -07:00
2017-11-02 11:10:55 +01:00
2019-08-06 19:06:52 +02:00
2017-11-02 11:10:55 +01:00
2021-01-30 13:32:11 +01:00
2021-03-24 11:07:31 +01:00
2020-12-30 11:25:40 +01:00
2021-01-23 15:49:55 +01:00
2019-02-27 10:08:53 +01:00
2021-10-06 15:31:17 +02:00
2018-01-08 17:30:45 +01:00
2017-11-02 11:10:55 +01:00
2021-05-26 11:48:35 +02:00
2021-11-26 11:36:02 +01:00
2017-11-02 11:10:55 +01:00
2018-04-11 10:28:38 -07:00
2013-12-29 15:25:48 +01:00
2013-09-13 15:09:52 +02:00
2019-11-12 19:21:38 +01:00
2021-08-08 08:54:30 +02:00
2021-10-06 15:31:28 +02:00
2015-11-16 09:27:32 +05:30
2017-11-02 11:10:55 +01:00
2020-10-01 13:14:28 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-26 17:08:40 +09:00
2021-03-04 09:39:57 +01:00
2021-08-26 08:36:41 -04:00
2021-01-23 15:49:55 +01:00
2018-05-08 13:02:42 +02:00
2018-03-16 19:58:27 +01:00
2017-11-02 11:10:55 +01:00
2017-11-15 11:56:19 -08:00
2017-11-02 11:10:55 +01:00
2021-03-11 14:05:02 +01:00
2021-10-27 09:53:13 +02:00
2020-06-25 15:33:02 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-12 17:33:38 -08:00
2017-11-02 11:10:55 +01:00
2018-01-01 12:40:27 -07:00
2018-06-26 11:33:04 +09:00
2018-04-27 11:53:02 -04:00
2018-08-25 13:40:38 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-04-07 12:48:50 +02:00
2017-08-07 17:22:14 +02:00
2013-09-26 15:06:58 -07:00
2021-12-08 08:50:13 +01:00
2021-11-26 11:35:59 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-12-08 08:50:13 +01:00
2021-09-22 11:47:56 +02:00
2021-09-22 11:47:56 +02:00
2021-01-30 13:32:12 +01:00
2019-12-05 09:21:03 +01:00
2021-03-11 14:04:59 +01:00
2018-08-02 10:24:51 +02:00
2017-11-02 11:10:55 +01:00
2019-02-12 19:47:24 +01:00
2022-01-27 09:04:25 +01:00
2020-01-04 19:13:32 +01:00
2021-07-11 12:49:27 +02:00
2021-09-22 11:48:09 +02:00
2018-03-08 12:30:37 +01:00
2012-10-13 10:46:48 +01:00
2021-05-22 10:59:40 +02:00
2021-03-04 09:39:59 +01:00
2018-06-04 10:58:12 -07:00
2021-03-30 14:37:00 +02:00
2018-08-15 10:25:26 -07:00
2021-08-26 08:36:39 -04:00
2018-07-21 10:43:12 -05:00
2017-11-02 11:10:55 +01:00
2014-05-14 16:40:04 -07:00
2017-10-19 16:54:49 -07:00
2021-02-03 23:23:26 +01:00
2017-09-08 18:26:49 -07:00
2017-11-02 11:10:55 +01:00
2021-05-22 10:59:50 +02:00
2012-12-09 00:20:28 -05:00
2021-12-08 08:50:11 +01:00
2018-06-22 13:43:27 +09:00
2021-03-04 09:39:59 +01:00
2021-08-26 08:36:40 -04:00
2017-11-02 11:10:55 +01:00
2021-01-09 13:43:48 +01:00
2017-11-02 11:10:55 +01:00
2019-07-21 09:03:11 +02:00
2017-11-02 11:10:55 +01:00
2021-03-04 09:39:42 +01:00
2021-03-04 09:39:44 +01:00
2017-11-02 11:10:55 +01:00
2018-08-18 11:44:53 -07:00
2021-12-08 08:50:12 +01:00
2021-02-07 14:48:38 +01:00
2021-09-26 13:39:46 +02:00
2021-11-26 11:35:57 +01:00
2017-12-01 13:09:40 -08:00
2021-09-22 11:47:57 +02:00
2018-04-17 13:42:48 +02:00
2018-04-12 09:41:19 -07:00
2021-11-26 11:35:56 +01:00
2015-08-10 14:29:27 +05:30
2017-11-02 11:10:55 +01:00
2021-04-28 13:16:51 +02:00
2018-12-29 13:37:59 +01:00
2017-11-02 11:10:55 +01:00
2017-01-04 13:22:38 -07:00
2021-10-09 14:11:03 +02:00
2019-04-17 08:38:51 +02:00
2021-09-22 11:48:12 +02:00
2020-01-29 16:43:27 +01:00
2018-05-14 13:14:23 -06:00
2021-07-11 12:49:28 +02:00
2021-07-11 12:49:26 +02:00
2020-07-29 10:16:52 +02:00
2021-05-22 10:59:23 +02:00
2017-11-02 11:10:55 +01:00
2017-11-15 13:46:33 -08:00
2017-11-02 11:10:55 +01:00
2018-03-24 11:25:35 -05:00
2021-08-26 08:36:41 -04:00
2021-03-30 14:37:02 +02:00
2021-06-30 08:48:18 -04:00
2021-07-20 16:16:01 +02:00
2022-02-08 18:23:08 +01:00
2021-07-20 16:16:11 +02:00
2020-10-07 08:00:08 +02:00
2020-04-13 10:45:06 +02:00
2017-11-02 11:10:55 +01:00
2021-12-08 08:50:11 +01:00
2018-01-08 08:22:45 -06:00
2021-01-06 14:45:00 +01:00
2021-09-03 09:58:00 +02:00
2018-07-08 11:13:25 +09:00
2021-08-08 08:54:30 +02:00
2021-07-11 12:49:30 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-09 10:23:28 +01:00
2021-11-26 11:36:19 +01:00
2018-03-19 10:09:44 -07:00
2018-08-22 10:52:45 -07:00
2021-06-10 13:24:08 +02:00
2018-01-03 10:38:54 -05:00
2018-07-21 10:43:12 -05:00
2018-07-07 17:52:26 +02:00
2012-10-13 10:46:48 +01:00
2017-09-08 18:26:51 -07:00
2021-07-20 16:15:46 +02:00
2017-11-02 11:10:55 +01:00
2021-01-12 20:10:17 +01:00
2017-11-02 11:10:55 +01:00
2021-06-30 08:48:19 -04:00
2019-01-09 17:38:33 +01:00
2017-11-02 11:10:55 +01:00
2018-02-12 11:43:25 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-06-08 18:52:26 -07:00
2018-07-17 09:27:43 +02:00
2018-08-09 11:15:06 +01:00
2017-11-03 15:24:11 +00:00
2019-12-05 09:19:38 +01:00
2017-11-02 11:10:55 +01:00
2021-07-11 12:49:28 +02:00
2021-11-26 11:36:14 +01:00
2020-01-27 14:50:37 +01:00
2018-07-25 11:22:19 +02:00
2021-12-14 10:18:04 +01:00
2022-02-23 11:58:38 +01:00
2017-11-02 11:10:55 +01:00
2021-11-26 11:35:56 +01:00
2020-04-02 15:28:22 +02:00
2018-03-22 21:30:56 -05:00
2020-12-30 11:26:01 +01:00
2018-02-01 09:46:00 -08:00
2020-06-22 09:05:03 +02:00
2017-11-02 11:10:55 +01:00
2018-08-22 10:52:43 -07:00
2017-12-19 09:26:00 +01:00
2021-12-08 08:50:13 +01:00
2018-05-17 12:46:54 -04:00
2021-09-22 11:48:11 +02:00
2021-05-22 10:59:39 +02:00
2021-06-30 08:48:18 -04:00
2017-01-12 09:33:39 +01:00
2018-07-26 10:50:16 -04:00
2018-05-30 10:11:34 +02:00
2018-05-30 10:11:34 +02:00
2016-03-25 16:37:42 -07:00
2018-06-14 12:21:18 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-06-05 16:57:31 -07:00
2017-11-02 11:10:55 +01:00
2021-03-17 16:43:51 +01:00
2021-02-13 13:51:15 +01:00
2018-04-28 15:01:14 -07:00
2009-04-10 15:48:52 +02:00
2020-01-27 14:50:22 +01:00
2017-08-18 14:07:26 -03:00
2017-11-02 11:10:55 +01:00
2018-02-06 18:32:47 -08:00
2021-03-07 12:19:01 +01:00
2017-11-02 11:10:55 +01:00
2022-01-05 12:34:57 +01:00
2021-03-24 11:07:37 +01:00
2019-12-21 10:57:17 +01:00
2018-04-17 17:18:04 +02:00
2017-11-02 11:10:55 +01:00
2021-10-09 14:11:04 +02:00
2017-11-02 11:10:55 +01:00
2020-12-30 11:26:01 +01:00
2017-12-04 07:14:30 -05:00
2018-07-09 09:07:54 -06:00
2021-07-20 16:15:42 +02:00
2021-05-22 10:59:31 +02:00
2020-12-11 13:25:01 +01:00
2021-03-30 14:36:58 +02:00
2017-11-02 11:10:55 +01:00
2021-03-24 11:07:34 +01:00
2018-04-23 13:41:55 +02:00
2018-08-16 09:57:20 -07:00
2015-12-04 10:38:59 -02:00
2021-12-29 12:20:44 +01:00
2017-12-08 16:37:50 +01:00
2020-04-29 16:31:27 +02:00
2018-04-11 10:28:30 -07:00
2017-11-02 11:10:55 +01:00
2018-05-03 09:25:47 -06:00
2021-12-14 10:18:06 +01:00
2018-05-18 08:47:13 -07:00
2018-04-11 10:28:39 -07:00
2021-03-07 12:19:01 +01:00