Add logic in DP driver to parse "label" dt property.
This info will be useful to configure DP as primary
or secondary.
Change-Id: I708179c5940c82256034bc6c8338b01ee52f2f79
Signed-off-by: Narender Ankam <nankam@codeaurora.org>
This change handles partial update use case transitions. Rounded
corner should be programmed to full ROI when transitioning out of
partial update use case.
This change also clear cached ROIs when rounded corner feature is
disabled to ensure full frame ROI for first frame when feature
is enabled again. This change depends on HAL change to disable PU
for one frame when RC mask config is set.
This change also moves cached rectangles from crtc state to crtc
structure to avoid cached rectangles being incorrect due to race
conditions between updating cached rectangles in crtc state and
duplicating crtc state when next commit starts.
Change-Id: I4c48ccd3f64409d1b0fa19f0e6f92eab5f86d099
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
This change handles partial update use case transitions. Rounded
corner should be programmed to full ROI when transitioning out of
partial update use case.
This change also clear cached ROIs when rounded corner feature is
disabled to ensure full frame ROI for first frame when feature
is enabled again.
Change-Id: I4c48ccd3f64409d1b0fa19f0e6f92eab5f86d099
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
Clear partial update mask during last close to avoid
rounded corner to be programmed without valid mask during
shell stop/start operations.
Change-Id: I378adc62b5bc5913abfc32fa3528c8e28ea273d4
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
Currently, driver expects usermode to set RC blob flags based on
the RC PU use case, which causes issue when commits are staggered
and is unnecessarily reprogramming RC mask data on every PU frame.
This change uses existing driver logic to internally determine the
RC PU use case and programs the RC region enable bits accordingly.
It also adds essential logging in RC functions to help debugging.
Change-Id: I19ae59a79dbee20f357b384c12acd7d2a6a93fb4
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
Clear partial update mask during last close to avoid
rounded corner to be programmed without valid mask during
shell stop/start operations.
Change-Id: I378adc62b5bc5913abfc32fa3528c8e28ea273d4
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
For the targets not having slave pll, "slave pll unavailable"
warning gets logged on suspend, resume and idle power collapse.
Change pr_warn to pr_debug to avoid extra logging.
Change-Id: I2f06d88f3ea8ceb03e30095439c24a6729daae97
Signed-off-by: Ravikanth Tuniki <rtunik@codeaurora.org>
This change updates rsvp_cur pointer to latest to avoid use
after free issues. rsvp_cur pointer can be freed in few cases due
to the unlock, wait and lock of rm_lock present in
_sde_rm_poll_get_rsvp_nxt_locked.
Change-Id: I389048188e8a615edc3e75dd1102d4ca8c74af65
Signed-off-by: Jayaprakash Madisetty <jmadiset@codeaurora.org>
During mode enable after idle, rsvp next would be set without
rsvp cur. Back to back test only should be serialized, but currently
this would be possible right after idle. This is established by
commit 11aab5f9c382 ("disp: msm: sde: Fix null dereference errors").
This change updates the condition to poll for rsvp next clear
during this usecase as well.
Change-Id: I300254967cbec69fff8b31545b8d659afc56f283
Signed-off-by: Nilaan Gunabalachandran <ngunabal@codeaurora.org>
Drm file is not set to NULL after freeing it from drm
release. This can result in use-after-free issues in
some scenarios. Add a mutex lock and other proper null
checks to prevent such issues.
Change-Id: Ic35b0a76166b0f47a354b1737e6f4c3ac1437ed4
Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
Signed-off-by: Althaf Neelanchirayil <aneelanc@codeaurora.org>
At present, code is checking only for MSM_REQ_ACK flag which is set for
read commands and ignores all other flag states.
This fix takes all the different states that are configured as the DSI
Command MIPI Flag states and sets it.
Also, added the backlight brightness control support with different DCS
command(0xC2) to update backlight brightness.
Change-Id: I689e902e7d997afcb629084e89e42361bf1c685b
Signed-off-by: Rajesh Bharathwaj <rajeshbharathwaj@codeaurora.org>
Add support for hardware based rounded corner part of
color processing framework.
Change-Id: Ie05c5ecba6bd0323d1c8fd6949e12cec1f56b477
Signed-off-by: Anjaneya Prasad Musunuri <aprasad@codeaurora.org>
Add support to use atomic variable instead of
spinlock for register logs during register
write. In the current architecture, register
writes are serialised and happen in commit
context.
Change-Id: I2a0b8ae404c94807ef06141867ee427909498ebf
Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
In targets where rsc is not supported minimum vote is not
present which might result in command fetch failures when
there is null commit. Made change to have minimum vote in such
cases.
Change-Id: Id7b58611cc9af8999b7112093fcf235950c8a1ee
Signed-off-by: Raviteja Tamatam <travitej@codeaurora.org>
Below is the sequence during which issue is observed
while using stale lut values:
1) Scaler block is enabled in the VIG pipe along with the
valid lut configuration.
2) Idle work gets scheduled and GDSC is turned off erasing
the saved lut values.
3) At the same time, userspace sends a commit assuming lut
values are still valid resulting in artifacts on the
screen.
In the plane state scaler config, only lut flag will be
reset for subsequent commits and remaining properties such
as filter cfgs, lut_idx etc. remains same. This change
caches the lut flag in sde plane whenever the lut is being
set and reuses this flag to handle above issue.
Change-Id: Ia6a2f3fb3fe2368f8accb4453082d11d7d75756b
Signed-off-by: Yashwanth <yvulapu@codeaurora.org>
During cwb usecases, connectors_changed flag will be
set and needs modeset condition will be set to true. This
change updates qsync concurrency check with modeset to
fail atomic check only if there is seamless poms, dms or
dynamic clock change scenario.
Change-Id: I78c214f9a6b08890b9b1618396becd3181c4a19b
Signed-off-by: Yashwanth <yvulapu@codeaurora.org>
Add changes to handle msm_preclose as part of msm_release
operation and remove preclose callback handler since legacy
feature is not supported for msm_driver.
Change-Id: I3e9930a96d8928586b1f76e9be4e3b334250cb7e
Signed-off-by: Jayaprakash <jmadiset@codeaurora.org>
Changes are made in check for external vote. So that, vote triggered
by change in control node at /sys/class/drm/card0/device/power is
considered to allow gdsc toggle.
Change-Id: I4644cae15930d9f92a7125f4d200f0502d53f0cd
Signed-off-by: Andhavarapu Karthik <kartkart@codeaurora.org>
Add changes to remove framebuffers attached to a drm_file
in preclose whose refcount is not managed by composer kill
and issue null flush to hardware in such cases. This will
avoid upstream issuing drm_atomic_commit's in drm_fb_release
which is leading to artifacts on screen or atomic_check failures
due to atomically unstaging each fb from plane_state and
committing remaining planes on hardware.
Change-Id: Ic197fb596a1dcfd1ebe2c83e759e619a1ab2f798
Signed-off-by: Jayaprakash <jmadiset@codeaurora.org>
Add changes to clear any dim_layers present in the crtc_state
as part of null commit.
Change-Id: Iaa5d01d7d512445e1524bac85012adda6be6c4a9
Signed-off-by: Jayaprakash <jmadiset@codeaurora.org>
Add changes to move the state operations for setting crtc to
connector state to a helper api. This can be reused during
preclose operation for issuing a drm commit.
Change-Id: I8daf4f2119c8d0e54c123a07255cb8119c2040ea
Signed-off-by: Jayaprakash <jmadiset@codeaurora.org>
This change allows event log and display ramdump
module compilation when DEBUG_FS config is in disabled
state.
Change-Id: Iae4f695da34aec1eb12581c74a101643e1a36669
Signed-off-by: Mahadevan <mahap@codeaurora.org>
Add changes to configure register writes in the event
log dump. The register writes can be enabled in the dump
through the debug_fs command.
Change-Id: I08154e193f670999746fbb30291a866db85c8c8d
Signed-off-by: Jayaprakash <jmadiset@codeaurora.org>
Currently, when using custom edid from debugfs, the
extensions data inside the edid block is not validated
before dereferencing the extension block.
The fix adds a edid validation function to validate
any custom edids before accessing any members in the
edid block.
Change-Id: I8a2cc45477416a8f8c4cff882bd53d14012e29f4
Signed-off-by: Sudarsan Ramesh <sudarame@codeaurora.org>
To avoid use after free issues this change gets latest rsvp_next pointer
in poll timeout scenario.
Change-Id: I4bd4ce1ce9d4f5f2df0e814ceb8babe544578fc6
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
Changes are made to add register write logs to memory dump.
This can be extracted from crash dumps and used for analysis.
Change-Id: I02038f62ecee86a9c82a913c6ed24bdd18465686
Signed-off-by: Andhavarapu Karthik <kartkart@codeaurora.org>
Pawan Chilka