Commit Graph
41 Commits
Author SHA1 Message Date
Ravikanth Tuniki 9f479d9b1c disp: pll: Improve logging for 7nm dsi pll
For the targets not having slave pll, "slave pll unavailable"
warning gets logged on suspend, resume and idle power collapse.
Change pr_warn to pr_debug to avoid extra logging.

Change-Id: I2f06d88f3ea8ceb03e30095439c24a6729daae97
Signed-off-by: Ravikanth Tuniki <rtunik@codeaurora.org>
2021-08-11 13:11:45 +05:30
Harigovindan P b12c580522 disp: pll: Add support for 7nm C-PHY shadow clock
Add support for 7nm DSI PLL C-PHY shadow clocks, which
will be used during dynamic dsi clock switch.

Change-Id: Iac131b9085d5541434f8480c14e7de4c8d014d2e
Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
2020-06-15 06:48:36 -07:00
Ritesh Kumar 44449c1e5c disp: pll: Fix cfg1 value when pclk_src_mux parent is updated
Currently, PLL_CFG1(1:0) register is updated with cached values
in dsi_pll_enable. This can create issue when UEFI and kernel
cfg1 programming is not same. To fix it, return cached value
of cfg1 when its read in pclk_mux_read, so that pclk_mux_write
is called and cached value is updated.

Change-Id: I1e45ff0685797bf4dd2e3a52af4753425f31edfc
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
2020-05-30 12:26:58 +05:30
Harigovindan P ee482d3c36 disp: pll: improve DSI PLL's performance
To improve performance margin for DSI's PLL at cold
temperature case, the value of DSIPHY_PLL_PLL_ICPMSET
should be changed from 0x24 to 0x3f.

Change-Id: I139e37e137355c5e8f0b3bebd28b23a09593dd13
Signed-off-by: Guchun Chen <guchunc@codeaurora.org>
Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
2020-05-11 10:37:28 +05:30
qctecmdr a9abdd9079 Merge "disp: msm: pll: add additional dividers for CPHY support" 2020-04-15 21:42:39 -07:00
Chandan Uddaraju 04eef944f5 disp: msm: pll: add additional dividers for CPHY support
Panels supporting Cphy use a specific divider
blocks. Add additional divider blocks for byte
and pixel clock output to support DSI CPHY.

Change-Id: I74b3ee2bdd22ae8fa20567fe837e03915537c4fb
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
2020-04-07 22:43:45 -07:00
RAJAT GUPTA 7d5a603a4b disp: pll: update clk names for lagoon target
Update clocks names for lagoon target according to clock
plan.

Change-Id: Ibc798a31d4234e4d6925ba9add2bb0ddb55909bc
Signed-off-by: RAJAT GUPTA <rajatgu@codeaurora.org>
2020-04-05 19:21:01 -07:00
RAJAT GUPTA 504afc1096 disp: pll: use 7nm dt-binding for 7nm pll driver
Use 7nm dt-binding for 7nm pll driver.

Change-Id: I50675a89db8b707fab05cac1aabaf0dd4f9ac4f4
Signed-off-by: RAJAT GUPTA <rajatgu@codeaurora.org>
2020-03-27 14:07:51 +05:30
Lipsa Rout 228df56150 techpack: disp: pll: Fix the clk get rate check in dsi pll
Updates the clk get rate check in dsi pll. This fixes
display clock voting for SVS instead of LSVS issue.

Change-Id: Ibdedd8f476d7a38858d18d233517699b61cf76f1
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
2020-03-13 14:04:59 +05:30
Lipsa Rout 42a3ef7061 techpack: disp: pll: power on PLL when reading PLL registers
Reading register of DSI PLL would fail if PLL is not powered
up, so enable DSI PLL power before reading operation.

Change-Id: Ie9933745035392744bb49241342f05a6be9daedc
Signed-off-by: Ray Zhang <rayz@codeaurora.org>
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
2020-03-13 14:03:58 +05:30
Ritesh Kumar 2a18ce9eda teckpack: disp: pll: Improve logging for 10nm dsi pll
Avoid warning of slave pll unavailable for chipsets
not having slave pll.

Change-Id: Id32af235f2fbefa4869b5c8236436e8e6ed84d60
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
2020-03-13 14:00:42 +05:30
Ritesh Kumar a3ba41f224 disp: pll: update 14nm PLL settings as per hardware recommendation
Add changes to update 14nm PLL settings as per latest hardware
recommendation.

Change-Id: Ib8729e14d6ce84e2c4c6a9c972d8a067a43f6e25
Signed-off-by: Vishnuvardhan Prodduturi <vproddut@codeaurora.org>
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
2020-02-13 15:49:59 +05:30
qctecmdr 64170700d2 Merge "clk: qcom: mdss: Remove recalculation of vco rate for 14nm pll" 2019-12-26 09:23:30 -08:00
qctecmdr c2be369b37 Merge "techpack: disp: pll: add support for dynamic refresh on DSI 14nm PLL" 2019-12-24 06:05:35 -08:00
Ritesh Kumar 32a7bf661d clk: qcom: mdss: Remove recalculation of vco rate for 14nm pll
In continuous splash use cases, the display is enabled in
the boot-loader. During display kernel probe, to enable clocks,
the rate is calculated by reading the hardware registers before
the corresponding software rate is set. At times when these rates
are nearly equal, the call for set rate never happens. This can
cause abnormal behavior. In this change during hand-off we don't
recalculate the clock rate to ensure the software programs the clock
registers accordingly.

Change-Id: I1dd448fdddb21a64ba48abe080a99f63976635dc
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
2019-12-24 02:10:09 -08:00
Lipsa Rout 6448a0ca94 techpack: disp: pll: add support for dynamic refresh on DSI 14nm PLL
Add CLK_SET_RATE_NO_REPARENT flag for the software mux clocks in
DSI 14nm PLL driver which is needed for dynamic refresh feature.

Change-Id: I581e8863abb6c2b46263cac83d115c2a3dd8796c
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
2019-12-19 19:05:45 +05:30
Aravind Venkateswaran 71d93edebb disp: pll: remove error log if supply entries are absent
PLL supply entry is no longer a mandatory property. Do not
report error if this entry is not present.

CRs-Fixed: 2588602
Change-Id: I1d8ff9e7e56f419c6a8984b69f64d61084e6c0f6
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
2019-12-17 16:37:38 -08:00
Ravikanth Tuniki 1e60728ab8 disp: msm: sde: Fix 32-bit compilation issues
1.Typecast to avoid distinct pointer type comparison
2.Keep DMA mask aligned with api definition.
3.Add Suffix for literals
4.Remove multfrac func to avoid uncompatible division.
5.64-bit division( operator "/") on 32-bit platforms is not supported.
  Using platform independent API's here

Change-Id: I0e7305418e53876bd1adf00c1963f85cbdf980cc
Signed-off-by: Ravikanth Tuniki <rtunik@codeaurora.org>
2019-10-24 14:48:40 +05:30
qctecmdr 517809d5ff Merge "disp: pll: update dynamic dsi clock sequence" 2019-09-20 07:35:56 -07:00
Ritesh Kumar c58801eec3 clk: qcom: mdss: remove recalculation of vco rate for 10nm pll
In continuous splash use cases, the display is enabled in
the boot-loader. During display kernel probe, to enable clocks,
the rate is calculated by reading the hardware registers before
the corresponding software rate is set. At times when these rates
are nearly equal, the call for set rate never happens. This can
cause abnormal behavior. In this change during hand-off we don't
recalculate the clock rate to ensure the software programs the clock
registers accordingly.

Change-Id: Ibe512067a134856c4f4364f57a80d50214e88397
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
2019-09-18 11:43:06 +05:30
Bruce Hoo 52eed6a827 disp: pll: update dynamic dsi clock sequence
Update dynamic dsi clock sequence for 7nm pll, change the register
which is used to store pre-cal code.

Change-Id: I0cd700f65a1dca965372adbda83416dfbbddd60f
Signed-off-by: Bruce Hoo <bingchua@codeaurora.org>
2019-09-03 16:31:46 +08:00
Yujun Zhang 80d06ebb7c disp: pll: limit clock rate of shadow VCO clock
Limit clock rate of shadow VCO clock as normal VCO clock.
For larger bit clock rate gap between switched ones, the clock switching
would fail due to mismatched VCO clock rate between normal VCO clock and
shadow one.

Change-Id: I9d68725de360ac28c243a3ce1800bfb139f39757
Signed-off-by: Yujun Zhang <yujunzhang@codeaurora.org>
2019-07-25 02:38:39 -07:00
Satya Rama Aditya Pinapala 7ea04a4d47 disp: pll: update DSI PHY PLL programming for Kona
This change updates the DSI PHY PLL programming for kona target
as per the hardware recommendation.

Change-Id: I706169fb635e72bd0ccd3057107ea749408733d0
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-18 12:41:38 -07:00
Ajay Singh Parmar e0e4280214 disp: pll: fix sequence as per hardware recommendations
Update the PLL and PHY power on and clock set sequence as per
the hardware recommendations. Move the post link clock phy enable
part to the catalog so that it can be programmed after enabling
link clock.

Change-Id: I9b3b49e5a9ac93bebcb1cb7da63b715a8d5ed85c
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
2019-07-12 16:44:05 -07:00
qctecmdr 5b2917a3c8 Merge "disp: pll: remove unsupported dividers for DSI pixel clock" 2019-06-28 02:53:01 -07:00
qctecmdr acf755573d Merge "disp: msm: dsi: DSI PHY V4 support of dynamic clock switch" 2019-06-27 03:34:31 -07:00
Sankeerth Billakanti 31d659e7e7 disp: pll: changes to support lito dp clks
Changes to incorporate the different clock names for
lito and kona.

Change-Id: I607366f75426a819226aa252819b507dba07109d
Signed-off-by: Sankeerth Billakanti <sbillaka@codeaurora.org>
2019-06-16 19:18:59 -07:00
Aravind Venkateswaran a545123901 disp: pll: remove unsupported dividers for DSI pixel clock
Remove dividers that are not recommended for DSI DPHY mode
when setting up the clock tree for the DSI pixel clock.

Change-Id: I2563a35ece541c1f5b46c72af7bd2cc79e72a90e
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
2019-06-11 16:38:34 -07:00
Yujun Zhang 6ec69969e2 disp: pll: add support for 7nm DSI PLL shadow clock
Add support for 7nm DSI PLL shadow clocks, which will be
used during dynamic dsi clock switch and dfps feature.

Change-Id: I870f961c7af4d404e61b45a4ad860ffb0e71ae7c
Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
Signed-off-by: Yujun Zhang <yujunzhang@codeaurora.org>
Signed-off-by: Ray Zhang <rayz@codeaurora.org>
2019-06-05 16:06:15 +08:00
Yujun Zhang 01c0dad6ee disp: pll: add support for 10nm DSI PLL shadow clock
Add support for 10nm DSI PLL shadow clocks, which will be
used during dynamic dsi clock switch and dfps feature.

Change-Id: Ib61bc5dcb5304bc1e3c7568c1419737580da3c88
Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Yujun Zhang <yujunzhang@codeaurora.org>
Signed-off-by: Ray Zhang <rayz@codeaurora.org>
2019-06-05 16:05:57 +08:00
qctecmdr ab3c7fdd80 Merge "disp: pll: update SSC offset value" 2019-05-21 07:34:58 -07:00
qctecmdr 366415bb0a Merge "disp: pll: fix TRACE_INCLUDE_FILE path issue" 2019-05-20 22:20:02 -07:00
qctecmdr 89a6e5d512 Merge "disp: msm: fix out-of-bound access and NULL dereference" 2019-05-19 16:45:53 -07:00
Samantha Tran 0cbfaf1a4b disp: msm: fix out-of-bound access and NULL dereference
Fix possible out-of-bound access and NULL pointer
dereference in SDE and PLL driver.

Change-Id: Ic5c34b3b4c3e983413a0351c38206cf3f3ab3b1f
Signed-off-by: Samantha Tran <samtran@codeaurora.org>
2019-05-17 11:30:48 -07:00
Narendra Muppalla 4e0078b8cf disp: pll: fix TRACE_INCLUDE_FILE path issue
This change address incorrect TRACE_INCLUDE_FILE issue
in pll driver.

Change-Id: I8d8d83f5cc93eb4700557d8b8564a949d0421caa
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
2019-05-14 12:44:55 -07:00
Satya Rama Aditya Pinapala 2f3a90b47d disp: pll: update SSC offset value
This change updates SSC offset value according to recent
hardware recommendation.

Change-Id: Ie822ed6ae8e383f93ca91615617dad4b4324b8a0
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-05-01 14:06:44 -07:00
Aravind Venkateswaran 664040053b disp: pll: fix divider clock flags for DSI PLL clocks
The divider clocks in the DSI PLL are 1-based and can accept
a value of 0. Set the flags accordingly in the PLL driver.

CRs-Fixed: 2433864
Change-Id: I82361ae3e2119f9e1922153bd5aba6354e8c5442
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
2019-05-01 12:53:51 -07:00
Aravind Venkateswaran acfd32f1b5 disp: pll: fix flags for DSI and DP PLL clocks
Remove the CLK_GET_RATE_NOCACHE flag from all the DP and DSI
pll clocks. This will eliminate the need to recalculate the
clock rates from HW registers when querying the rates for the
PLL clocks. This will ensure that no unclocked register accesses
are done when these clocks are queried while the display core
is power collapsed.

Change-Id: Ia5e993195cadc2bced32c052bb604e9980ecd4d8
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
2019-04-23 16:54:41 -07:00
Satya Rama Aditya Pinapala bda5e6a968 disp: pll: remove recalculation of vco rate
In continuous splash use cases, the display is enabled in
the boot-loader. During display kernel probe, to enable clocks,
the rate is calculated by reading the hardware registers before 
the corresponding software rate is set. At times when these rates
are nearly equal, the call for set rate never happens. This can
cause abnormal behavior. In this change during hand-off we don't
recalculate the clock rate to ensure the software programs the clock
registers accordingly.

Change-Id: I421c523ffd48a0cb73d7721c6d74c8e68aa6d9a5
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-04-22 10:48:45 -07:00
Narendra Muppalla 11c9fc4e92 disp: avoid encoder-connector checks with cont-splash
When continuous splash is enabled, connector states
are not properly updated with the encoder associated
with it. This is by design, so avoid all making
such request there by avoiding unnecessary errors
during the bootup. Fix a handful of warnings in
the PLL definition files

Change-Id: I7f08c5ff80ea2a2bfb4b19f2ea13c8f9cbb833e8
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
2019-04-14 22:21:13 -07:00
Narendra Muppalla 3709853456 Display drivers kernel project initial snapshot
This change brings msm display driver including sde,
dp, dsi, rotator, dsi pll and dp pll from base 4.19 kernel
project. It is first source code snapshot from base kernel project.

Change-Id: Iec864c064ce5ea04e170f24414c728684002f284
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
2019-04-14 22:20:59 -07:00